Feature #1020

Ability to choose subtitles

Added by Andreas Lunderhage 12 months ago. Updated 6 months ago.

Status:NewStart date:06/02/2012
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:WEB UI
Target version:-

Description

It would be nice to be able to configure which subtitle track to use for the vlc plugin in the WebUI.

Pretty annoying with finnish subs when I am swede and it is not even possible to turn them of.

Here are some examples how it is done:
http://forum.videolan.org/viewtopic.php?t=33190

So it is just about adding another parameter and burping it out in the player window.

vlc_test.html Magnifier (1.33 KB) Andreas Lunderhage, 06/03/2012 10:06 pm

subtitles.patch Magnifier - Subtitle update (19.4 KB) Andreas Lunderhage, 06/07/2012 09:21 pm

History

#1 Updated by Hein Rigolo 12 months ago

can you come up with a patch that could implement this?
here is location where the vlc plugin gets called in the source:

/ src / webui / static / app / tvheadend.js

Hein

#2 Updated by Andreas Lunderhage 12 months ago

I have spent the evening to find out how it works...

I have found out that the stream has to be started before it is possible to determine if we have subtitles, which ones and then set the one we want.

Then the question is how it should work in Tvheadend.

Either we can add another combo box to the player window in case the stream has subtitles. Or we can add a config parameter and then try to set that one if it is possible. Then we don't bloat the player window. I would prefer the later one.

What do you think?

#3 Updated by Andreas Lunderhage 12 months ago

This is my suggestion about how it should be done.

I turning the subtitles off by default. Then I have added a button to cycle through the available subtitles including turning them off again. Also the active subtitles is shown in the video window for short moment so you know what you have chosen.

Only thing missing is an icon for the button, maybe it should be a "T"?

#4 Updated by Hein Rigolo 12 months ago

why a "T" ... and not a "S"?
Or how about a icon that is a square with a little line just above the bottom? (to mimic the position of the subtitles)
And can you set a tooltip for the icon?

Hein

#5 Updated by Adam Sutton 6 months ago

  • Category set to WEB UI

#6 Updated by Walter Purcaro 6 months ago

Patches are gone. :(

#7 Updated by Adam Sutton 6 months ago

It's a bug in redmine (related to the upgrade) and Andreas is on the case.

Adam

#8 Updated by Walter Purcaro 6 months ago

okay, meanwhile I'll try to make it alone. ;)

#9 Updated by Andreas Lunderhage 6 months ago

What do you mean with "patches are gone"? It is in this thread. Then if it has made it's way to the repo yet, I don't know.

#10 Updated by Adam Sutton 6 months ago

Andreas, see my note above it was a redmine bug which has now been fixed.

Adam

#11 Updated by Walter Purcaro 6 months ago

Thanks :)

Also available in: Atom PDF